Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update status of FLIP 120 #246

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Update status of FLIP 120 #246

merged 1 commit into from
Apr 13, 2024

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Feb 5, 2024

update status to implemented

@tarakby tarakby requested a review from a team February 5, 2024 12:59
@KshitijChaudhary666
Copy link
Contributor

KshitijChaudhary666 commented Feb 28, 2024

Hi @tarakby - this FLIP is not reflected on FLIP project tracker. Did you follow the process outlined in https://github.com/onflow/flips? Specifically please remember to do the following without which the FLIP won't get visibility on the project tracker -->

Create an issue by using one of the FLIP issue templates based on the type of the FLIP - application, governance, cadence or protocol. The title of the issue should be the title of your FLIP, e.g., "Dynamic Inclusion fees". Submit the issue. Note the issue number that gets assigned.
Then, Create your FLIP as a pull request to this repository (onflow/flips). Use the issue number generated in step 2 as the FLIP number. And mention the FLIP issue by copying the GitHub URL or the issue in the comment section.

Thanks!

@tarakby
Copy link
Contributor Author

tarakby commented Feb 29, 2024

Hey @KshitijChaudhary666, thanks for pointing the FLIP process steps.

I believe the FLIP process got updated after I created FLIP 120. You can notice the FLIP PR started on July 13, and at that time the FLIP number would be the PR number. The extra step 2 of going through creating an issue was added on August 23.

Btw the same happened for FLIP 123. I hope it's possible to manually fix the tracker for both.

@KshitijChaudhary666
Copy link
Contributor

Hey @KshitijChaudhary666, thanks for pointing the FLIP process steps.

I believe the FLIP process got updated after I created FLIP 120. You can notice the FLIP PR started on July 13, and at that time the FLIP number would be the PR number. The extra step 2 of going through creating an issue was added on August 23.

Btw the same happened for FLIP 123. I hope it's possible to manually fix the tracker for both.

Hey! Got it - thanks for sharing the details. Could you pls create two issues (for each flip) in the new format and mark the right "type" (Cadence) and "status" (implemented?) and that should bring them to the project tracker. Thanks, really appreciate it!

@tarakby
Copy link
Contributor Author

tarakby commented Feb 29, 2024

If I create 2 issues, the FLIPs won't have the issues numbers because they were already merged long time ago (and we always referred to them as 120 and 123). Wouldn't that mess with the tracker?

@vishalchangrani
Copy link
Contributor

If I create 2 issues, the FLIPs won't have the issues numbers because they were already merged long time ago (and we always referred to them as 120 and 123). Wouldn't that mess with the tracker?

Hi @tarakby - for such cases, l basically change the FLIP ID to be the issue ID (if the FLIP is fairly new). Else, create the issue and mention in the issue description the original FLIP it points to.

@tarakby
Copy link
Contributor Author

tarakby commented Apr 12, 2024

here is the issue #260.
I also created the issue #261 for a related FLIP.

Feel free to merge or close the current PR.

@tarakby tarakby merged commit aadc0d9 into main Apr 13, 2024
1 check passed
@tarakby tarakby deleted the tarak/update-status branch April 13, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants